Removed useless Number() calls

This commit is contained in:
Alexis
2024-04-03 22:56:57 +02:00
parent 10e5cf7a1a
commit 614e29cf24
3 changed files with 49 additions and 43 deletions

View File

@@ -11,8 +11,8 @@ const daysPerMonth = computed(() => staticConfig.daysPerMonth)
function getNextMonthDate(day: number): LeimDate { function getNextMonthDate(day: number): LeimDate {
let nextDay = day let nextDay = day
let nextMonth = Number(currentDate.currentMonth) + 1 let nextMonth = currentDate.currentMonth + 1
let nextYear = Number(currentDate.currentYear) let nextYear = currentDate.currentYear
let nextPeriod = currentDate.currentPeriod let nextPeriod = currentDate.currentPeriod
// If the new value would exceed the max number of month per year // If the new value would exceed the max number of month per year
@@ -59,8 +59,8 @@ const moveCalendarRight = useThrottleFn(() => {
:key="day" :key="day"
:date="{ :date="{
day: day, day: day,
month: Number(currentDate.currentMonth), month: currentDate.currentMonth,
year: Number(currentDate.currentYear), year: currentDate.currentYear,
period: currentDate.currentPeriod period: currentDate.currentPeriod
}" }"
/> />

View File

@@ -18,10 +18,10 @@ type CalendarCurrentConfig = {
} }
type CalendarCurrentDate = { type CalendarCurrentDate = {
currentDay: ComputedRef<string | string[]> currentDay: ComputedRef<number>
currentMonth: ComputedRef<string | string[]> currentMonth: ComputedRef<number>
currentMonthName: ComputedRef<string> currentMonthName: ComputedRef<string>
currentYear: ComputedRef<string | string[]> currentYear: ComputedRef<number>
currentPeriod: Ref<LeimPeriod> currentPeriod: Ref<LeimPeriod>
currentPeriodAbbr: Ref<LeimPeriodShort> currentPeriodAbbr: Ref<LeimPeriodShort>
currentDateTitle: ComputedRef<string> currentDateTitle: ComputedRef<string>
@@ -77,52 +77,58 @@ export const useCalendar = defineStore('calendar', () => {
}) })
// Default date settings (current day) // Default date settings (current day)
const defaultDay = String(12) const defaultDay = 12
const defaultMonth = String(7) const defaultMonth = 7
const defaultYear = String(3209) const defaultYear = 3209
const defaultDate: ComputedRef<LeimDate> = computed(() => { const defaultDate: ComputedRef<LeimDate> = computed(() => {
return { return {
day: Number(defaultDay), day: defaultDay,
month: Number(defaultMonth), month: defaultMonth,
year: Number(defaultYear), year: defaultYear,
period: 'nante' period: 'nante'
} }
}) })
// Assign default values if no params exist in URL // Assign default values if no params exist in URL
if (!params.day) { if (!params.day) {
params.day = defaultDay params.day = defaultDay.toString()
} }
if (!params.month) { if (!params.month) {
params.month = defaultMonth params.month = defaultMonth.toString()
} }
if (!params.year) { if (!params.year) {
params.year = defaultYear params.year = defaultYear.toString()
} }
const currentDay = computed(() => params.day) const currentDay = computed(() => {
return Number(params.day)
})
const currentMonth = computed(() => params.month) const currentMonth = computed(() => {
return Number(params.month)
})
// Gets the label from currentMonth index // Gets the label from currentMonth index
const currentMonthName = computed(() => getMonthName(Number(currentMonth.value))) const currentMonthName = computed(() => getMonthName(currentMonth.value))
const currentYear = computed(() => params.year) const currentYear = computed(() => {
return Number(params.year)
})
// Get period from currentYear // Get period from currentYear
const currentPeriod: ComputedRef<LeimPeriod> = computed( const currentPeriod: ComputedRef<LeimPeriod> = computed(
() => getPeriodOfYear(Number(currentYear.value)).long () => getPeriodOfYear(currentYear.value).long
) )
const currentPeriodAbbr: ComputedRef<LeimPeriodShort> = computed( const currentPeriodAbbr: ComputedRef<LeimPeriodShort> = computed(
() => getPeriodOfYear(Number(currentYear.value)).short () => getPeriodOfYear(currentYear.value).short
) )
const currentDateTitle = computed(() => { const currentDateTitle = computed(() => {
switch (currentConfig.value.viewType) { switch (currentConfig.value.viewType) {
case 'month': case 'month':
return getFormattedDateTitle({ return getFormattedDateTitle({
day: Number(currentDate.currentDay.value), day: currentDate.currentDay.value,
month: Number(currentDate.currentMonth.value), month: currentDate.currentMonth.value,
year: Number(currentDate.currentYear.value), year: currentDate.currentYear.value,
period: currentDate.currentPeriod.value period: currentDate.currentPeriod.value
}) })
@@ -130,10 +136,10 @@ export const useCalendar = defineStore('calendar', () => {
return `Année ${currentYear.value} ${currentPeriodAbbr.value}` return `Année ${currentYear.value} ${currentPeriodAbbr.value}`
case 'decade': case 'decade':
return `Années ${Number(currentYear.value)} ${getPeriodOfYear(Number(currentYear.value)).short} - ${Number(currentYear.value) + 10} ${getPeriodOfYear(Number(currentYear.value) + 10).short}` return `Années ${currentYear.value} ${getPeriodOfYear(currentYear.value).short} - ${currentYear.value + 10} ${getPeriodOfYear(currentYear.value + 10).short}`
case 'century': case 'century':
return `Années ${Number(currentYear.value)} ${getPeriodOfYear(Number(currentYear.value)).short} - ${Number(currentYear.value) + 100} ${getPeriodOfYear(Number(currentYear.value) + 100).short}` return `Années ${currentYear.value} ${getPeriodOfYear(currentYear.value).short} - ${currentYear.value + 100} ${getPeriodOfYear(currentYear.value + 100).short}`
default: default:
return 'Date inconnue' return 'Date inconnue'
@@ -152,9 +158,9 @@ export const useCalendar = defineStore('calendar', () => {
} }
const currentLeimDate: LeimDate = { const currentLeimDate: LeimDate = {
day: Number(currentDay.value), day: currentDay.value,
month: Number(currentMonth.value), month: currentMonth.value,
year: Number(currentYear.value), year: currentYear.value,
period: currentPeriod.value period: currentPeriod.value
} }
@@ -162,14 +168,14 @@ export const useCalendar = defineStore('calendar', () => {
switch (currentConfig.value.viewType) { switch (currentConfig.value.viewType) {
case 'month': case 'month':
return ( return (
defaultDate.value.month === Number(currentDate.currentMonth.value) && defaultDate.value.month === currentDate.currentMonth.value &&
defaultDate.value.year === Number(currentDate.currentYear.value) defaultDate.value.year === currentDate.currentYear.value
) )
case 'year': case 'year':
case 'decade': case 'decade':
case 'century': case 'century':
return defaultDate.value.year === Number(currentDate.currentYear.value) return defaultDate.value.year === currentDate.currentYear.value
default: default:
return false return false
@@ -297,9 +303,9 @@ export const useCalendar = defineStore('calendar', () => {
} }
function jumpToDefaultDate() { function jumpToDefaultDate() {
params.day = defaultDay params.day = defaultDay.toString()
params.month = defaultMonth params.month = defaultMonth.toString()
params.year = defaultYear params.year = defaultYear.toString()
currentConfig.value.viewType = 'month' currentConfig.value.viewType = 'month'
} }

View File

@@ -93,23 +93,23 @@ export const useCalendarEvents = defineStore('calendar-events', () => {
switch (currentConfig.viewType) { switch (currentConfig.viewType) {
case 'month': case 'month':
return ( return (
event.date.month === Number(currentDate.currentMonth) || event.date.month === currentDate.currentMonth ||
(event.date.month === Number(currentDate.currentMonth) + 1 && event.date.day <= 8) // This is to allow leap events from appearing on the last 8 tiles (event.date.month === currentDate.currentMonth + 1 && event.date.day <= 8) // This is to allow leap events from appearing on the last 8 tiles
) )
case 'year': case 'year':
return event.date.year === Number(currentDate.currentYear) return event.date.year === currentDate.currentYear
case 'decade': case 'decade':
return ( return (
event.date.year >= Number(currentDate.currentYear) && event.date.year >= currentDate.currentYear &&
event.date.year <= Number(currentDate.currentYear) + 10 event.date.year <= currentDate.currentYear + 10
) )
case 'century': case 'century':
return ( return (
event.date.year >= Number(currentDate.currentYear) && event.date.year >= currentDate.currentYear &&
event.date.year <= Number(currentDate.currentYear) + 100 event.date.year <= currentDate.currentYear + 100
) )
default: default: